This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] Add some more casts (1/2)
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Fri, 25 Sep 2015 14:17:12 +0100
- Subject: Re: [PATCH 2/2] Add some more casts (1/2)
- Authentication-results: sourceware.org; auth=none
- References: <1443036644-583-1-git-send-email-simon dot marchi at ericsson dot com>
Simon Marchi <simon.marchi@ericsson.com> writes:
> - const struct signal_catchpoint *c = (void *) bl->owner;
> + const struct signal_catchpoint *c =
> + (const struct signal_catchpoint *) bl->owner;
Nit here: "=" should be put the beginning of next line, like
const struct signal_catchpoint *c
= (const struct signal_catchpoint *) bl->owner;
GNU Coding Standards says "When you split an expression into multiple
lines, split it before an operator, not after one." There are multiple
instances of this problem.
OK with them fixed.
--
Yao (éå)