RE: [PATCH 6/6] btrace: use gdb_disassembly_vec and new source interleaving method

["Metzger, Markus T" <markus dot t dot metzger at intel dot com>]

> -----Original Message-----
> From: Andrew Burgess [mailto:andrew.burgess@embecosm.com]
> Sent: Monday, September 21, 2015 11:48 PM
> To: Metzger, Markus T
> Cc: palves@redhat.com; dje@google.com; gdb-patches@sourceware.org
> Subject: Re: [PATCH 6/6] btrace: use gdb_disassembly_vec and new source
> interleaving method

Hello Andrew,

Thanks for your feedback.


> > Use the new source interleaving method.  We stick to the /m modifier.
> > The old version is broken and there's no point in keeping it as alternative
> > to this new version.
> >
> >  /* The to_insn_history method of target record-btrace.  */
> > diff --git a/gdb/record.c b/gdb/record.c
> > index 71ef973..c17b199 100644
> > --- a/gdb/record.c
> > +++ b/gdb/record.c
> > @@ -458,7 +458,7 @@ get_insn_history_modifiers (char **arg)
> >  	  switch (*args)
> >  	    {
> >  	    case 'm':
> > -	      modifiers |= DISASSEMBLY_SOURCE_DEPRECATED;
> > +	      modifiers |= DISASSEMBLY_SOURCE;
> >  	      modifiers |= DISASSEMBLY_FILENAME;
> >  	      break;
> >  	    case 'r':
> 
> I think that we should make /s the official modifier in order to match
> the disassembler modifier.
> 
> We should definitely keep /m for backwards compatibility, though I
> don't have an issue with it's behaviour changing to match /s.  My
> concern is more about trying to keep the flags consistent as much as
> possible.  The change in flags would need a NEWS and manual update.

Adding '/s' is fine with me.

Regards,
Markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Prof. Dr. Hermann Eul
Chairperson of the Supervisory Board: Tiffany Doon Silva
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928