This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3] xtensa: initialize call_abi in xtensa_tdep
- From: Max Filippov <jcmvbkbc at gmail dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org, Maxim Grigoriev <maxim2405 at gmail dot com>, Woody LaRue <larue at cadence dot com>, Marc Gauthier <marc at cadence dot com>
- Date: Mon, 31 Aug 2015 12:03:35 +0300
- Subject: Re: [PATCH v3] xtensa: initialize call_abi in xtensa_tdep
- Authentication-results: sourceware.org; auth=none
- References: <1440078815-14369-1-git-send-email-jcmvbkbc at gmail dot com> <20150828003722 dot GB4388 at adacore dot com>
On Fri, Aug 28, 2015 at 3:37 AM, Joel Brobecker <brobecker@adacore.com> wrote:
>> Use XSHAL_ABI value provided by xtensa-config.h to correctly initialize
>> xtensa_tdep.call_abi
>> This fixes calls to functions from GDB that otherwise fail with the
>> following assertion in call0 configuration:
>>
>> gdb/regcache.c:602: internal-error: regcache_raw_read: Assertion
>> `regnum >= 0 && regnum < regcache->descr->nr_raw_registers' failed.
>>
>> gdb/
>> * xtensa-tdep.h (XTENSA_GDBARCH_TDEP_INSTANTIATE): Initialize
>> call_abi using XSHAL_ABI macro.
>
> I may have missed the end of the discussion about how to properly
> build for your target. But, in the meantime, I don't think your patch
> is amking things all that worse, and perhaps even easier for others
> to have a functional GDB, so the patch is OK with me. Pedro, please
> yell if you think I'm wrong to approve.
I've committed this patch to master. Thanks!
-- Max