This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/8] Add new gdbarch method, unconditional_branch_address
- From: Pedro Alves <palves at redhat dot com>
- To: Kevin Buettner <kevinb at redhat dot com>, gdb-patches at sourceware dot org
- Date: Tue, 25 Aug 2015 13:13:49 +0100
- Subject: Re: [PATCH 2/8] Add new gdbarch method, unconditional_branch_address
- Authentication-results: sourceware.org; auth=none
- References: <20150818235334 dot 1afb0c85 at pinnacle dot lan> <20150819000002 dot 06f6a2cf at pinnacle dot lan>
On 08/19/2015 08:00 AM, Kevin Buettner wrote:
> +# Examine instruction at PC. If instruction at PC is an unconditional
> +# branch, return the address to which control is transferred when the
> +# branch is taken. Return 0 when this method is not implemented by
> +# architecture, PC refers to an invalid address, or instruction at PC
> +# is not an unconditional branch.
> +m:CORE_ADDR:unconditional_branch_address:CORE_ADDR pc:pc::default_unconditional_branch_address::0
> +
In addition to the comments in the other patch, I wonder if we would
better name this in terms of a higher level concept, around
"breakpoint address" instead of a "low level branch destination"?
Thanks,
Pedro Alves