This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3 04/19] Implement completion limiting for add_filename_to_list.
- From: Doug Evans <xdje42 at gmail dot com>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sat, 22 Aug 2015 18:06:19 -0700
- Subject: Re: [PATCH v3 04/19] Implement completion limiting for add_filename_to_list.
- Authentication-results: sourceware.org; auth=none
- References: <20150806191404 dot 32159 dot 50755 dot stgit at valrhona dot uglyboxes dot com> <20150806191537 dot 32159 dot 4525 dot stgit at valrhona dot uglyboxes dot com>
Keith Seitz <keiths@redhat.com> writes:
> Differences in this revision:
>
> 1. Remove partial copy code from add_filename_to_list.
>
> ---
>
> This patch converts add_filename_to_list to implement completion limiting.
> This function is used by both make_source_files_completion_list
> and maybe_add_partial_symbol. Tests have been added for both code
> pathways.
>
> gdb/ChangeLog
>
> * symtab.c (add_filename_to_list): Add completer_data argument and
> update all callers.
> Use add_completion.
>
> gdb/testsuite/ChangeLog
>
> * gdb.base/filesym.c (filesym2): Add external declaration.
> * gdb.base/filesym.exp: Compile newly added files.
> Add tests for completion limiting.
> * gdb.base/filesym2.c, gdb.base/filesym3.c, gdb.base/filesym4.c,
> gdb.base/filesym5.c: New files.
LGTM