This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v6 5/9] Explicit locations: introduce probe locations
- From: Doug Evans <xdje42 at gmail dot com>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 10 Aug 2015 11:05:11 -0700
- Subject: Re: [PATCH v6 5/9] Explicit locations: introduce probe locations
- Authentication-results: sourceware.org; auth=none
- References: <20150805232802 dot 21646 dot 88440 dot stgit at valrhona dot uglyboxes dot com> <20150805233007 dot 21646 dot 43939 dot stgit at valrhona dot uglyboxes dot com>
Keith Seitz <keiths@redhat.com> writes:
> * This patch has previously been approved. *
>
> This patch adds support for probe locations and converts existing
> probe linespec locations to the new location type.
>
> gdb/ChangeLog:
>
> * break-catch-throw.c (re_set_exception_catchpoint): Convert
> linespec for stap probe to probe location.
> * breakpoint.c (create_longjmp_master_breakpoint)
> (create_exception_master_breakpoint): Likewise.
> (break_command_1): Remove local variable `arg_cp'.
> Check location type to set appropriate breakpoint ops methods.
> (trace_command): Likewise.
> * linespec.c (event_location_to_sals): Assert on probe locations.
> * location.c (EL_PROBE): Add macro definition.
> (new_probe_location, get_probe_location): New functions.
> (copy_event_location, delete_event_location, event_location_to_string)
> (string_to_event_location, event_location_empty_p): Handle probe
> locations.
> * location.h (enum event_location_type): Add PROBE_LOCATION.
> (new_probe_location, get_probe_location): Declare.
> * probe.c (parse_probes): Assert that LOCATION is a probe location.
> Convert linespec into probe location.
Still approved.