This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix instruction skipping when using software single step in gdbserver.




On 08/04/2015 01:18 PM, Joel Brobecker wrote:
Just a small trivial comment while scanning the patch...

--- a/gdb/gdbserver/mem-break.c
+++ b/gdb/gdbserver/mem-break.c
@@ -1660,6 +1660,21 @@ hardware_breakpoint_inserted_here (CORE_ADDR addr)
    return 0;
  }

+int
+reinsert_breakpoint_inserted_here (CORE_ADDR addr)

Can you add the standard bread crumb comment that indicates that
the function is in fact documented, and where that documentation
is? Eg:

/* See mem-break.h.  */

Thank you! :)


Right, I'll add it now :)

Thanks,


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]