This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix instruction skipping when using software single step in gdbserver.
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Antoine Tremblay <antoine dot tremblay at ericsson dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 4 Aug 2015 10:18:23 -0700
- Subject: Re: [PATCH] Fix instruction skipping when using software single step in gdbserver.
- Authentication-results: sourceware.org; auth=none
- References: <1438353367-24936-1-git-send-email-antoine dot tremblay at ericsson dot com>
Just a small trivial comment while scanning the patch...
> --- a/gdb/gdbserver/mem-break.c
> +++ b/gdb/gdbserver/mem-break.c
> @@ -1660,6 +1660,21 @@ hardware_breakpoint_inserted_here (CORE_ADDR addr)
> return 0;
> }
>
> +int
> +reinsert_breakpoint_inserted_here (CORE_ADDR addr)
Can you add the standard bread crumb comment that indicates that
the function is in fact documented, and where that documentation
is? Eg:
/* See mem-break.h. */
Thank you! :)
--
Joel