This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/7] New regs_info for aarch32


On 07/31/2015 04:16 PM, Yao Qi wrote:
> @@ -973,9 +916,8 @@ initialize_low_arch (void)
>    /* Initialize the Linux target descriptions.  */
>    init_registers_arm ();
>    init_registers_arm_with_iwmmxt ();

Why weren't these moved as well?  At first,

> -  init_registers_arm_with_vfpv2 ();
> -  init_registers_arm_with_vfpv3 ();
> -  init_registers_arm_with_neon ();
> +
> +  initialize_low_arch_aarch32 ();

I thought that this was because aarch64 doesn't
do the old iwmmxt, but then in the following patch you
have this anyway:

>  void
>  initialize_low_arch_aarch32 (void)
>  {
> +#ifndef __aarch64__
>    init_registers_arm_with_vfpv2 ();
>    init_registers_arm_with_vfpv3 ();
> +#endif
>    init_registers_arm_with_neon ();
>

So I don't understand when/where to initialize arm32
descriptions going forward.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]