This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] [AArch64] Rename boolean arguments in decoding functions
- From: Pierre Langlois <pierre dot langlois at arm dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: pierre dot langlois at arm dot com, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Thu, 30 Jul 2015 12:41:29 +0100
- Subject: Re: [PATCH] [AArch64] Rename boolean arguments in decoding functions
- Authentication-results: sourceware.org; auth=none
- References: <1438162390-30381-1-git-send-email-pierre dot langlois at arm dot com> <864mklga6z dot fsf at gmail dot com>
On 30/07/15 12:24, Yao Qi wrote:
> Pierre Langlois <pierre.langlois@arm.com> writes:
>
>> * aarch64-tdep.c (decode_b): Rename link argument to is_bl.
>> Change its type to int *.
>> (decode_br): Rename link argument to is_blr. Change its type to
>> int *.
>> (decode_cb): Rename op argument to is_cbnz. Change its type to
>> int *.
>> (decode_tb): Rename op argument to is_tbnz. Change its type to
>> int *. Set is_tbnz to either 1 or 0.
>> (aarch64_analyze_prologue): Change type of is_link to int. Add
>> new variables is_cbnz and is_tbnz. Adjust call to
>> aarch64_decode_cb and aarch64_decode_tb.
>
> Patch looks good to me.
>
Thanks Yao, I've pushed this in.
Thanks,
Pierre