This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] PR record/18691: Fix fails in solib-precsave.exp
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>, gdb-patches at sourceware dot org
- Date: Wed, 29 Jul 2015 10:43:02 +0100
- Subject: Re: [PATCH] PR record/18691: Fix fails in solib-precsave.exp
- Authentication-results: sourceware.org; auth=none
- References: <1438154258-16402-1-git-send-email-yao dot qi at linaro dot org>
On 07/29/2015 08:17 AM, Yao Qi wrote:
> and we want to GDB read memory across targets, which means if the
> requested memory isn't found in record-core, GDB can read memory from
> core, and exec even further if needed. I find raw_memory_xfer_partial
> is exactly what I want.
LGTM.
> diff --git a/gdb/target.h b/gdb/target.h
> index 32234f7..75b830d 100644
> --- a/gdb/target.h
> +++ b/gdb/target.h
> @@ -265,6 +265,11 @@ typedef enum target_xfer_status
> ULONGEST len,
> ULONGEST *xfered_len);
>
> +enum target_xfer_status
> +raw_memory_xfer_partial (struct target_ops *ops, gdb_byte *readbuf,
> + const gdb_byte *writebuf, ULONGEST memaddr, LONGEST len,
> + ULONGEST *xfered_len);
Being a declaration, the function name shouldn't be on column 0, but
on column 2 instead.
Thanks,
Pedro Alves