This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/5] Consider addressable memory unit size in various value functions
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
- Date: Tue, 28 Jul 2015 11:29:54 +0100
- Subject: Re: [PATCH 4/5] Consider addressable memory unit size in various value functions
- Authentication-results: sourceware.org; auth=none
- References: <1437072684-26565-1-git-send-email-simon dot marchi at ericsson dot com> <1437072684-26565-4-git-send-email-simon dot marchi at ericsson dot com> <55B22120 dot 5010707 at redhat dot com> <55B6AB27 dot 707 at ericsson dot com>
On 07/27/2015 11:05 PM, Simon Marchi wrote:
> - offset += TYPE_FIELD_BITPOS (arg_type, fieldno) / 8;
> + offset += TYPE_FIELD_BITPOS (arg_type, fieldno) /
> + (HOST_CHAR_BIT * unit_size);
wrap in parens so alignment ends up correct (per gnu coding conventions),
and put / operator at beginning of line:
offset += (TYPE_FIELD_BITPOS (arg_type, fieldno)
/ (HOST_CHAR_BIT * unit_size));
OK with that change.
Thanks,
Pedro Alves