This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Have SIGTERM promptly quit GDB even when the dummy target is active
- From: Patrick Palka <patrick at parcs dot ath dot cx>
- To: Pedro Alves <palves at redhat dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 27 Jul 2015 11:43:54 -0400
- Subject: Re: [PATCH] Have SIGTERM promptly quit GDB even when the dummy target is active
- Authentication-results: sourceware.org; auth=none
- References: <1437762829-5214-1-git-send-email-patrick at parcs dot ath dot cx> <55B645E1 dot 7060809 at redhat dot com> <55B64C5E dot 8060009 at redhat dot com>
On Mon, Jul 27, 2015 at 11:21 AM, Pedro Alves <palves@redhat.com> wrote:
> On 07/27/2015 03:53 PM, Pedro Alves wrote:
>> On 07/24/2015 07:33 PM, Patrick Palka wrote:
>>
>>> gdb/ChangeLog:
>>>
>>> * event-top.c (handle_sigterm): Don't inspect
>>> target_can_async_p. Always set the quit flag and always mark
>>> the async signal handler.
>>
>> OK.
>
> BTW, I notice that GDB leaves the terminal settings broken
> after exiting on SIGTERM. Is that something you're already
> looking at? (Mostly likely there's a target_terminal_ours
> missing somewhere.)
I think we should do target_terminal_ours in quit_force. (A similar
problem also exists in our SIGWINCH handler.)