This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] gdb/gdbtypes: fix handling of typedef layers between array types


> gdb/ChangeLog:
> 
> 	* gdbtypes.c (resolve_dynamic_array): Pass the peeled element
> 	type to the recursive call instead of the original (maybe
> 	TYPE_CODE_TYPEDEF) type.
> 
> gdb/testsuite/ChangeLog:
> 
> 	* gdb.ada/var_arr_typedef.exp: New testcase.
> 	* gdb.ada/var_arr_typedef/pack.adb: New file.
> 	* gdb.ada/var_arr_typedef/pack.ads: New file.
> 	* gdb.ada/var_arr_typedef/var_arr_typedef.adb: New file.

Looks good to go overall, with one nit (missing bit in the copyright
header of the Ada code, as seen below).

For the record, I believe the patch was tested on x86_64-linux.

Pre-approved with the nits fixed.

> diff --git a/gdb/testsuite/gdb.ada/var_arr_typedef/pack.adb b/gdb/testsuite/gdb.ada/var_arr_typedef/pack.adb
> new file mode 100644
> index 0000000..82f034b
> --- /dev/null
> +++ b/gdb/testsuite/gdb.ada/var_arr_typedef/pack.adb
> @@ -0,0 +1,23 @@
> +--  This program is free software; you can redistribute it and/or modify
> +--  it under the terms of the GNU General Public License as published by

Missing the "Copyright (C) 2015 Free [...]" line at the start of
this Ada file, and all others.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]