This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v9 09/10] Validate symbol file using build-id
- From: Doug Evans <dje at google dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: Pedro Alves <palves at redhat dot com>, Eli Zaretskii <eliz at gnu dot org>, gdb-patches <gdb-patches at sourceware dot org>, Aleksandar Ristovski <ARistovski at qnx dot com>
- Date: Tue, 14 Jul 2015 09:13:26 -0700
- Subject: Re: [PATCH v9 09/10] Validate symbol file using build-id
- Authentication-results: sourceware.org; auth=none
- References: <20150614192542 dot 18346 dot 87859 dot stgit at host1 dot jankratochvil dot net> <20150614192655 dot 18346 dot 17075 dot stgit at host1 dot jankratochvil dot net> <20150621101644 dot GA12733 at host1 dot jankratochvil dot net> <CADPb22TH5nfFSkCzW9cCiHuoJFAG+P5z=qZawgwGUgYQ5kfd5Q at mail dot gmail dot com> <20150623204702 dot GA2156 at host1 dot jankratochvil dot net> <559D3749 dot 9010200 at redhat dot com> <20150712190921 dot GA8682 at host1 dot jankratochvil dot net> <20150712192911 dot GB12553 at host1 dot jankratochvil dot net> <83vbdp8846 dot fsf at gnu dot org> <55A39439 dot 1090803 at redhat dot com> <20150713123835 dot GA2529 at host1 dot jankratochvil dot net>
On Mon, Jul 13, 2015 at 5:38 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> On Mon, 13 Jul 2015 12:34:33 +0200, Pedro Alves wrote:
>> As the plan is for the feature to apply to the main executable too,
>> it's better that "solib" isn't part of the setting name. I agree
>> that "validate-build-id" sounds better than "build-id-validation".
>
> OK, so validate-build-id or solib-validate-build-id.
>
> Just this series being approved is still only for shlib and I do not yet have
> completely finished the second series for all binaries; although 7.10 is
> branched so till 7.11 there is now really enough time to have it all.
>
> So I do not know if I should call it in this shlib-only first series as
> validate-build-id or as solib-validate-build-id.
One of the important bits for me is to not add an option knowing
we're going to rename it later.
We've just branched 7.10 and I'm guessing all of this will be
present for 7.11.
So I'd be ok with just adding a simple note somewhere saying
the option only applies to solibs at the moment and will
eventually also apply to exes.