This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH 1/4] int -> enum target_hw_bp_type in aarch64-linux-nat.c
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: gdb-patches at sourceware dot org
- Date: Tue, 7 Jul 2015 16:22:55 +0100
- Subject: [PATCH 1/4] int -> enum target_hw_bp_type in aarch64-linux-nat.c
- Authentication-results: sourceware.org; auth=none
- References: <1436282578-8070-1-git-send-email-yao dot qi at linaro dot org>
This patch is to use 'enum target_hw_bp_type' instead of int for
breakpoint type, in order to make some functions in GDB and
GDBserver looks similar.
gdb:
2015-07-06 Yao Qi <yao.qi@linaro.org>
* aarch64-linux-nat.c (aarch64_dr_state_insert_one_point): Change
argument type's type to 'enum target_hw_bp_type'.
(aarch64_dr_state_remove_one_point): Likewise.
(aarch64_handle_breakpoint): Likewise.
(aarch64_linux_insert_hw_breakpoint): Likewise.
(aarch64_linux_remove_hw_breakpoint): Likewise.
(aarch64_handle_aligned_watchpoint): Likewise.
---
gdb/aarch64-linux-nat.c | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/gdb/aarch64-linux-nat.c b/gdb/aarch64-linux-nat.c
index 9959b81..94093fc 100644
--- a/gdb/aarch64-linux-nat.c
+++ b/gdb/aarch64-linux-nat.c
@@ -1036,7 +1036,8 @@ aarch64_point_is_aligned (int is_watchpoint, CORE_ADDR addr, int len)
static int
aarch64_dr_state_insert_one_point (struct aarch64_debug_reg_state *state,
- int type, CORE_ADDR addr, int len)
+ enum target_hw_bp_type type, CORE_ADDR addr,
+ int len)
{
int i, idx, num_regs, is_watchpoint;
unsigned int ctrl, *dr_ctrl_p, *dr_ref_count;
@@ -1108,7 +1109,8 @@ aarch64_dr_state_insert_one_point (struct aarch64_debug_reg_state *state,
static int
aarch64_dr_state_remove_one_point (struct aarch64_debug_reg_state *state,
- int type, CORE_ADDR addr, int len)
+ enum target_hw_bp_type type, CORE_ADDR addr,
+ int len)
{
int i, num_regs, is_watchpoint;
unsigned int ctrl, *dr_ctrl_p, *dr_ref_count;
@@ -1163,7 +1165,8 @@ aarch64_dr_state_remove_one_point (struct aarch64_debug_reg_state *state,
/* Implement insertion and removal of a single breakpoint. */
static int
-aarch64_handle_breakpoint (int type, CORE_ADDR addr, int len, int is_insert)
+aarch64_handle_breakpoint (enum target_hw_bp_type type, CORE_ADDR addr,
+ int len, int is_insert)
{
struct aarch64_debug_reg_state *state;
@@ -1191,7 +1194,7 @@ aarch64_linux_insert_hw_breakpoint (struct target_ops *self,
int ret;
CORE_ADDR addr = bp_tgt->placed_address = bp_tgt->reqstd_address;
const int len = 4;
- const int type = hw_execute;
+ const enum target_hw_bp_type type = hw_execute;
if (show_debug_regs)
fprintf_unfiltered
@@ -1224,7 +1227,7 @@ aarch64_linux_remove_hw_breakpoint (struct target_ops *self,
int ret;
CORE_ADDR addr = bp_tgt->placed_address;
const int len = 4;
- const int type = hw_execute;
+ const enum target_hw_bp_type type = hw_execute;
if (show_debug_regs)
fprintf_unfiltered
@@ -1249,8 +1252,8 @@ aarch64_linux_remove_hw_breakpoint (struct target_ops *self,
from that it is an aligned watchpoint to be handled. */
static int
-aarch64_handle_aligned_watchpoint (int type, CORE_ADDR addr, int len,
- int is_insert)
+aarch64_handle_aligned_watchpoint (enum target_hw_bp_type type, CORE_ADDR addr,
+ int len, int is_insert)
{
struct aarch64_debug_reg_state *state
= aarch64_get_debug_reg_state (ptid_get_pid (inferior_ptid));
--
1.9.1