This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/4] windows-nat: Replace __COPY_CONTEXT_SIZE conditional with __CYGWIN__
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Jon TURNEY <jon dot turney at dronecode dot org dot uk>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 12 Jun 2015 08:56:20 -0400
- Subject: Re: [PATCH 2/4] windows-nat: Replace __COPY_CONTEXT_SIZE conditional with __CYGWIN__
- Authentication-results: sourceware.org; auth=none
- References: <1433352592-9728-1-git-send-email-jon dot turney at dronecode dot org dot uk> <1433352592-9728-4-git-send-email-jon dot turney at dronecode dot org dot uk> <20150609185505 dot GI2855 at adacore dot com> <5578382E dot 8010408 at dronecode dot org dot uk>
> >>2015-06-03 Jon Turney <jon.turney@dronecode.org.uk>
> >>
> >> * windows-nat.c (do_windows_fetch_inferior_registers)
> >> (handle_output_debug_string): Replace __COPY_CONTEXT_SIZE
> >> conditional with __CYGWIN__.
> >
> >FWIW, I don't mind this patch, but I don't necessarily see what
> >we are gaining from it. Can you explain?
>
> There are still some problems with Cygwin signal handling [1], which I hope
> to fix, and this is a bit of clean-up preparatory to that.
>
> This also makes it clear that the code which uses __COPY_CONTEXT_SIZE is
> Cygwin specific.
>
> [1] https://sourceware.org/ml/gdb-patches/2015-06/msg00180.html
OK, patch is approved.
Thank you,
--
Joel