This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 7/9 v2] Implement multiple-filesystem support for remote targets
- From: Pedro Alves <palves at redhat dot com>
- To: Gary Benson <gbenson at redhat dot com>, gdb-patches at sourceware dot org
- Cc: Eli Zaretskii <eliz at gnu dot org>, Doug Evans <dje at google dot com>, Iago López Galeiras <iago at endocode dot com>
- Date: Thu, 21 May 2015 16:04:05 +0100
- Subject: Re: [PATCH 7/9 v2] Implement multiple-filesystem support for remote targets
- Authentication-results: sourceware.org; auth=none
- References: <1429186791-6867-1-git-send-email-gbenson at redhat dot com> <1430395542-16017-8-git-send-email-gbenson at redhat dot com>
On 04/30/2015 01:05 PM, Gary Benson wrote:
> @@ -9890,6 +9935,9 @@ remote_hostio_open (struct target_ops *self,
> char *p = rs->buf;
> int left = get_remote_packet_size () - 1;
>
> + if (remote_hostio_set_filesystem (inf, remote_errno) != 0)
> + return -1;
I guess this is where the ENOSYS issue (and likewise in the native
target) we were discussing before (in the vgdb patch) comes from.
I'm not yet convinced it's a good idea to have setns==ENOSYS result
in open==ENOSYS.
Other than this issue, the whole series looks good to me.
Thanks,
Pedro Alves