This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/4] gdb: Remove register class specific layout names.
- From: Pedro Alves <palves at redhat dot com>
- To: Andrew Burgess <andrew dot burgess at embecosm dot com>, gdb-patches at sourceware dot org
- Date: Thu, 21 May 2015 14:17:12 +0100
- Subject: Re: [PATCH 1/4] gdb: Remove register class specific layout names.
- Authentication-results: sourceware.org; auth=none
- References: <cover dot 1432163460 dot git dot andrew dot burgess at embecosm dot com> <90740f3ef5bac701c1653d469fcc9d34fb113517 dot 1432163460 dot git dot andrew dot burgess at embecosm dot com> <20150521122510 dot GJ2880 at embecosm dot com>
On 05/21/2015 01:25 PM, Andrew Burgess wrote:
>
> * Pedro Alves <palves@redhat.com> [2015-05-21 09:12:45 +0100]:
>> Doesn't your series effectively make this bit in display_command dead?
>> (while before it would switch on the registers layout).
>
> Sorry for missing that use.
>
> You're right, it's certainly dead now, though before my patch it still
> didn't do anything, passing the '$FREGS', etc names to
> tui_set_layout_for_display_command would just cause the regs display
> to pop up with the default register set. (At least, that's all I
> ever see, and I don't think anything else is possible.)
Right, that's what I saw.
>
> Given that it's not worked for a while, I propose to just remove the
> above snippet (really having this in display seems nasty to me) and
> just move to layout being for layout adjustment, and 'tui reg' to
> change the displayed register set.
Agreed.
>
>> (We should probably
>> rename tui_set_layout_for_display_command too.)
>
> Done, it's now tui_set_layout_by_name.
>
>> I had never noticed these special register layouts before either. I'm not
>> at all adverse to removing them. Not all expressions that start with $ are
>> registers, and probably a better idea would be to have
>> a separate "displays" window (so displays would go to that window
>> instead of the command window when the TUI is active), so that the tui
>> could neatly show watched variables/random expressions too.
>
> Sounds like a good idea.
>
> New patch below.
OK.
Thanks,
Pedro Alves