This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] When can we remove Sun-specific stabs support? (when will it be ok to delete partial_symtab.section_offsets?)


On Thu, May 7, 2015 at 3:52 PM, Doug Evans <dje@google.com> wrote:
> ...
> IIUC, and assuming I'm not missing anything,
> this has been broken since at least gdb 7.0 (I didn't
> check back any further).
> The code was a little different back then, but the free_elfinfo
> cleanup was still done before building psymtabs.
>
> Sufficient motivation for deleting this code now?

I'm guessing this is the patch, from 2003.

2003-02-20  Daniel Jacobowitz  <drow@mvista.com>

        * coffread.c (coff_symfile_read): Clean up minimal symbols earlier.
        * dbxread.c (elfstab_build_psymtabs): Don't call
        install_minimal_symbols.
        (stabsect_build_psymtabs): Likewise.
        * elfread.c (elf_symfile_read): Call install_minimal_symbols
        earlier.
        * somread.c (som_symfile_read): Call install_minimal_symbols
        and do_cleanups earlier.
        * nlmread.c (nlm_symfile_read): Likewise.
        * mdebugread.c (elfmdebug_build_psymtabs): Call
        install_minimal_symbols and make appropriate cleanups.

[there's a typo in the date of the c/l entry, which I fixed after cut-n-pasting]

So, assuming I'm not missing anything, we haven't supported
this hack for Sun stabs since 2003.

Patch to delete it completely to follow,
unless there's a REALLY good reason to keep it.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]