This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] When can we remove Sun-specific stabs support? (when will it be ok to delete partial_symtab.section_offsets?)
- From: Doug Evans <dje at google dot com>
- To: gdb-patches <gdb-patches at sourceware dot org>
- Date: Thu, 7 May 2015 16:04:47 -0700
- Subject: Re: [RFC] When can we remove Sun-specific stabs support? (when will it be ok to delete partial_symtab.section_offsets?)
- Authentication-results: sourceware.org; auth=none
- References: <90e6ba6e87129285600515847ec6 at google dot com> <CADPb22QOG+A-kRaiY1PvRU8bnEw-L2EHzb5eOiSiX2GAQZ50GA at mail dot gmail dot com>
On Thu, May 7, 2015 at 3:52 PM, Doug Evans <dje@google.com> wrote:
> ...
> IIUC, and assuming I'm not missing anything,
> this has been broken since at least gdb 7.0 (I didn't
> check back any further).
> The code was a little different back then, but the free_elfinfo
> cleanup was still done before building psymtabs.
>
> Sufficient motivation for deleting this code now?
I'm guessing this is the patch, from 2003.
2003-02-20 Daniel Jacobowitz <drow@mvista.com>
* coffread.c (coff_symfile_read): Clean up minimal symbols earlier.
* dbxread.c (elfstab_build_psymtabs): Don't call
install_minimal_symbols.
(stabsect_build_psymtabs): Likewise.
* elfread.c (elf_symfile_read): Call install_minimal_symbols
earlier.
* somread.c (som_symfile_read): Call install_minimal_symbols
and do_cleanups earlier.
* nlmread.c (nlm_symfile_read): Likewise.
* mdebugread.c (elfmdebug_build_psymtabs): Call
install_minimal_symbols and make appropriate cleanups.
[there's a typo in the date of the c/l entry, which I fixed after cut-n-pasting]
So, assuming I'm not missing anything, we haven't supported
this hack for Sun stabs since 2003.
Patch to delete it completely to follow,
unless there's a REALLY good reason to keep it.