This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/3] Introduce function for directly updating GDB's screen dimensions
- From: Pedro Alves <palves at redhat dot com>
- To: Patrick Palka <patrick at parcs dot ath dot cx>, gdb-patches at sourceware dot org
- Date: Tue, 28 Apr 2015 13:09:07 +0100
- Subject: Re: [PATCH 1/3] Introduce function for directly updating GDB's screen dimensions
- Authentication-results: sourceware.org; auth=none
- References: <1429836801-14218-1-git-send-email-patrick at parcs dot ath dot cx>
Thanks for doing this.
LGTM. One nit below.
On 04/24/2015 01:53 AM, Patrick Palka wrote:
>
> diff --git a/gdb/utils.c b/gdb/utils.c
> index a9350d9..ec2fd87 100644
> --- a/gdb/utils.c
> +++ b/gdb/utils.c
> @@ -1795,6 +1795,18 @@ set_height_command (char *args, int from_tty, struct cmd_list_element *c)
> set_screen_size ();
> }
>
> +/* Set the screen dimensions to WIDTH and HEIGHT. */
> +
> +void
We're putting public function comments in the headers nowadays.
So could you please move the describing comment to utils.h, and
put a breadcrumb here instead:
/* See utils.h. */
> +set_screen_width_and_height (int width, int height)
> +{
Thanks,
Pedro Alves