This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Use exec_file_find to prepend gdb_sysroot in follow_exec
- From: Pedro Alves <palves at redhat dot com>
- To: Gary Benson <gbenson at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 28 Apr 2015 12:31:05 +0100
- Subject: Re: [PATCH] Use exec_file_find to prepend gdb_sysroot in follow_exec
- Authentication-results: sourceware.org; auth=none
- References: <1429277318-26646-1-git-send-email-gbenson at redhat dot com> <553E5CF7 dot 7090309 at redhat dot com> <20150428112912 dot GA17957 at blade dot nx>
On 04/28/2015 12:29 PM, Gary Benson wrote:
> Pedro Alves wrote:
>> We now have at least two places that need to remember to call close.
>> IWBN if we hid that close in a exec_file_find variant, so that
>> callers didn't have to recall to do it. Maybe rename exec_file_find
>> to (e.g.) exec_file_find_fd and reuse the exec_file_find name, even.
>
> Good shout. How about I fix solib_find_1 to accept fd == NULL, and
> put the closing logic in there? That
Sounds good.
> would work for solib_find too then (I'm not sure if there are
> any "solib_find; close" places in GDB but I'll look.)
Thanks,
Pedro Alves