This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix gdb.guile/scm-parameter.exp path matching
- From: Andy Wingo <wingo at igalia dot com>
- To: Doug Evans <dje at google dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 28 Apr 2015 11:17:35 +0200
- Subject: Re: [PATCH] Fix gdb.guile/scm-parameter.exp path matching
- Authentication-results: sourceware.org; auth=none
- References: <87a8yhh413 dot fsf at igalia dot com> <21803 dot 61561 dot 579082 dot 793515 at ruffy2 dot mtv dot corp dot google dot com>
On Mon 13 Apr 2015 18:36, Doug Evans <dje@google.com> writes:
> Andy Wingo writes:
> > OK to commit? For me the test was failing for
> > srcdir=/home/wingo/src/binutils-gdb/+2.0/../gdb/testsuite.
> >
> > Andy
> >
> > >From 9eed15669df55cc792353e44d041a64af5249177 Mon Sep 17 00:00:00 2001
> > From: Andy Wingo <wingo@igalia.com>
> > Date: Thu, 9 Apr 2015 14:32:54 +0200
> > Subject: [PATCH] Fix gdb.guile/scm-parameter.exp path matching
> >
> > gdb/testsuite/ChangeLog:
> >
> > * gdb.guile/scm-parameter.exp: Escape the path that we are
> > matching against, as it might contain characters that are special
> > to regular expressions.
>
> LGTM with one nit.
> Can you add a similar fix to gdb.python/py-parameter.exp?
>
> Hmmm, there's also the is_remote_host test that
> lives in py-parameter.exp (git show 10c5f0a8), which
> isn't in scm-parameter.exp, but no need to do that here.
Done and pushed, thanks.
Andy