This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] Do not manipulate "target:" filenames as local paths
- From: Gary Benson <gbenson at redhat dot com>
- To: Doug Evans <dje at google dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 27 Apr 2015 15:42:26 +0100
- Subject: Re: [PATCH v2] Do not manipulate "target:" filenames as local paths
- Authentication-results: sourceware.org; auth=none
- References: <20150414114129 dot GB4660 at blade dot nx> <1429085001-25894-1-git-send-email-gbenson at redhat dot com> <21818 dot 38520 dot 332957 dot 849560 at ruffy2 dot mtv dot corp dot google dot com>
Doug Evans wrote:
> Gary Benson writes:
> >
> > This patch alters two places that manipulate object file filenames
> > to detect "target:" filenames and to not attempt to manipulate them
> > as paths on the local filesystem:
> >
> > - allocate_objfile is updated to not attempt to expand "target:"
> > filenames with gdb_abspath.
> >
> > - load_auto_scripts_for_objfile is updated to not attempt to load
> > auto-load scripts for object files with "target:" filenames.
> >
> > Built and regtested on RHEL6.6 x86_64.
> >
> > Ok to commit?
> >
> > gdb/ChangeLog:
> >
> > * objfiles.c (allocate_objfile): Do not attempt to expand name
> > if name is a "target:" filename.
> > * auto-load.c (load_auto_scripts_for_objfile): Do not attempt
> > to load auto-load scripts for objfiles with "target:" filenames.
>
> Thanks for the ping.
>
> LGTM.
Thanks Doug, I pushed it.
Cheers,
Gary
--
http://gbenson.net/