This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/4] S390: Restructure s390_push_dummy_call
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: arnez at linux dot vnet dot ibm dot com (Andreas Arnez)
- Cc: gdb-patches at sourceware dot org, sergiodj at redhat dot com (Sergio Durigan Junior)
- Date: Thu, 23 Apr 2015 18:03:10 +0200 (CEST)
- Subject: Re: [PATCH 2/4] S390: Restructure s390_push_dummy_call
- Authentication-results: sourceware.org; auth=none
Andreas Arnez wrote:
> * s390-linux-tdep.c
> (is_float_singleton): Remove function. Move the "singleton" part
> of the logic...
> (s390_effective_inner_type): ...here. New function.
> (is_float_like): Remove function. Inline its logic...
> (s390_function_arg_float): ...here.
> (is_pointer_like, is_integer_like, is_struct_like): Remove
> functions. Inline their logic...
> (s390_function_arg_integer): ...here.
> (s390_function_arg_pass_by_reference): Remove function.
> (extend_simple_arg): Remove function.
> (alignment_of): Remove function.
> (struct s390_arg_state): New structure.
> (s390_handle_arg): New function.
> (s390_push_dummy_call): Move parameter placement logic to the new
> function s390_handle_arg. Call it for calculating the stack area
> sizes first, and again for actually writing the parameters.
This is OK.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com