This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 03/24] Fix gdb.base/interrupt.exp racy fail against gdbserver
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 23 Apr 2015 15:58:19 +0100
- Subject: Re: [PATCH 03/24] Fix gdb.base/interrupt.exp racy fail against gdbserver
- Authentication-results: sourceware.org; auth=none
- References: <1429639711-16459-1-git-send-email-palves at redhat dot com> <1429639711-16459-4-git-send-email-palves at redhat dot com> <86pp6uyl52 dot fsf at gmail dot com>
On 04/23/2015 03:28 PM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
>
>> Fix this by removing $inferior_spawn_id from the set of spawn ids
>> expect is watching as soon as we see the "end of file" string out of
>> the inferior spawn id, using an indirect spawn id list.
>>
>
> Yeah, it is clever to use indirect spawn ids here...
>
>> Tested on x86-64 Fedora 20, native and gdbserver (both target remote
>> and extended-remote).
>>
>> gdb/testsuite/ChangeLog:
>> 2015-04-21 Pedro Alves <palves@redhat.com>
>>
>> * gdb.base/interrupt.exp: Rename saw_eof to saw_end_of_file. Use
>
> The first sentence can be removed, it is in 02/24.
>
>> an indirect spawn id list holding $inferior_spawn_id instead of
>> $inferior_spawn_id directly. On "of of file", remove
>
> On "end of file".
>
>> $inferior_spawn_id from the indirect list.
>
> Patch is good to me.
Thanks Yao, I fixed ChangeLog and went ahead and pushed in
patches 1-3, in order to plug the race in the buildbots.
Thanks,
Pedro Alves