This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix MI dprintf-insert not printing when a location is pending.

From: Antoine Tremblay <antoine dot tremblay at ericsson dot com>
To: <gdb-patches at sourceware dot org>
Date: Mon, 20 Apr 2015 08:14:10 -0400
Subject: Re: [PATCH] Fix MI dprintf-insert not printing when a location is pending.
Authentication-results: sourceware.org; auth=none
References: <55154E63 dot 5040603 at ericsson dot com> <1427459819-29661-1-git-send-email-antoine dot tremblay at ericsson dot com> <55158AAF dot 7010709 at redhat dot com> <55158F97 dot 7030400 at ericsson dot com> <55159493 dot 20005 at redhat dot com>

ping...

On 03/27/2015 01:34 PM, Keith Seitz wrote:

On 03/27/2015 10:12 AM, Antoine Tremblay wrote:

However there is still a problem forcing me to use gdb_expect I think,
namely mi_gdb_test waits for a command prompt like so :

-re "^($string_regex\[\r\n\]+)?($pattern\[\r\n\]+$mi_gdb_prompt\[ \]*)"

However dprintf does mean you will get a prompt printed...

You will get a prompt only when hitting the breakpoint I placed.


Ick. Yeah, you are right. My bad.

I could remove mi_expect_stop at the end and assume that breakpoint will
not fail but I think it's not right ? also mi-dprintf.exp is using the
same mi_run_cmd / gdb_expect / mi_expect_stop ...

What do you think ?


I think everything is fine as it is. Sorry about the noise.

So, once again, while I am not a maintainer, I recommend a maintainer
approve this patch.

Thank you for your patience,
Keith

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]