This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Mark object files with "target:" filenames as OBJF_NONLOCAL_FILENAME
- From: Pedro Alves <palves at redhat dot com>
- To: Doug Evans <dje at google dot com>, Gary Benson <gbenson at redhat dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Wed, 15 Apr 2015 09:56:50 +0100
- Subject: Re: [PATCH] Mark object files with "target:" filenames as OBJF_NONLOCAL_FILENAME
- Authentication-results: sourceware.org; auth=none
- References: <1428952063-2121-1-git-send-email-gbenson at redhat dot com> <CADPb22THqPa3WzQUK13Oh_-AF0D3GNitSmUBQcj7mZoBp0pL8A at mail dot gmail dot com>
On 04/14/2015 12:27 AM, Doug Evans wrote:
> While I'm all for building on "foo:bar" in path names
> (target:foo, remote:foo, and so on), IWBN to build a library on top of that
> rather than have sideband tables that recorded such extra info.
> [Down the road I can imagine having a class for such things such that
> we could augment what's recorded beyond just a "foo:bar" string, but
> that's later, if ever.]
I agree. I like that -- I can definitely see us with
something like a "struct gdb_path" object rather than a passing
around a bare char * / string.
>
> IOW, how about having an "is non-local" predicate that is invoked on
> the path whenever needed?
> [it could be the current "is_target_filename" or if you wanted to add
> a layer of abstraction that might be ok, depending on how this might
> evolve]
I agree, for now is_target_filename seems good.
>
> I realize this is a bit incongruous with OBJF_NOT_FILENAME, but I'd
> rather head in the above direction than adding more OBJF_ flags.
*nod*
Thanks,
Pedro Alves