This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Zero supplied stat buffers in functions that pretend to stat
- From: Gary Benson <gbenson at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 14 Apr 2015 12:37:49 +0100
- Subject: Re: [PATCH] Zero supplied stat buffers in functions that pretend to stat
- Authentication-results: sourceware.org; auth=none
- References: <1428961250-23031-1-git-send-email-gbenson at redhat dot com> <552C3AF4 dot 4000604 at redhat dot com> <20150414080403 dot GA524 at blade dot nx>
Gary Benson wrote:
> Pedro Alves wrote:
> > On 04/13/2015 10:40 PM, Gary Benson wrote:
> > > GDB has five places where it pretends to stat for bfd_openr_iovec.
> > > Four of these only set the incoming buffer's st_size, leaving the
> > > other fields unchanged, which is to say very likely populated with
> > > random values from the stack. remote_bfd_iovec_stat was fixed in
> > > 0a93529c56714b1da3d7106d3e0300764f8bb81c; this commit fixes the
> > > other four.
> > >
> > > Built and and regtested on RHEL6.6 x86_64.
> > >
> > > Ok to commit?
> >
> > Eh, how apropos for the bfd cache discussion.
>
> Yeah, I've been meaning to reply to that :)
>
> > OK, thanks.
>
> Will push it later.
Pushed.
Cheers,
Gary
--
http://gbenson.net/