This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/3] gdb: New maintenance command to disable bfd sharing.
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Andrew Burgess <andrew dot burgess at embecosm dot com>
- Cc: gdb-patches at sourceware dot org, andrew dot burgess at embecosm dot com
- Date: Mon, 13 Apr 2015 23:14:55 +0300
- Subject: Re: [PATCH 2/3] gdb: New maintenance command to disable bfd sharing.
- Authentication-results: sourceware.org; auth=none
- References: <cover dot 1428941320 dot git dot andrew dot burgess at embecosm dot com> <cover dot 1428941320 dot git dot andrew dot burgess at embecosm dot com> <f20bee016bff03711d3d8962606aabad1fee4a67 dot 1428941320 dot git dot andrew dot burgess at embecosm dot com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Cc: Andrew Burgess <andrew.burgess@embecosm.com>
> Date: Mon, 13 Apr 2015 18:30:08 +0100
>
> In some rare maintainer cases it is desirable to be able to disable bfd
> sharing. This patch adds new commands maintenance set/show commands for
> bfd-sharing, allowing gdb's bfd cache to be turned off.
>
> OK to apply?
The documentation parts are okay, although...
> + add_setshow_boolean_cmd ("bfd-sharing", no_class,
> + &bfd_sharing, _("\
> +Set whether gdb will share bfds that appear to be the same file."), _("\
> +Show whether gdb will share bfds that appear to be the same file."), _("\
> +Tells gdb whether to share bfds that appear to be the same file. The\n\
> +modification time and file size are used to determine if a file on\n\
> +disc has changed."),
...there appears to be some redundancy in the doc string here.
Also, the new command should be in gdb.texinfo as well.
Thanks.