This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Unset tcl variable addr to avoid clashing
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Doug Evans <dje at google dot com>
- Cc: Yao Qi <qiyaoltc at gmail dot com>, gdb-patches <gdb-patches at sourceware dot org>
- Date: Mon, 13 Apr 2015 02:46:56 -0400
- Subject: Re: [RFC] Unset tcl variable addr to avoid clashing
- Authentication-results: sourceware.org; auth=none
- References: <1428666671-12926-1-git-send-email-qiyaoltc at gmail dot com> <87r3rqppgq dot fsf at redhat dot com> <CADPb22QcfoJqK15FjHSbownWbT-0FpJ3KLQWdOCe7Ud7B_0oAQ at mail dot gmail dot com>
On Sunday, April 12 2015, Doug Evans wrote:
>> FWIW, there is not strong reason to keep the variable name as "addr" in
>> the testcase. So, an easier solution would be to rename the variable to
>> something else, like "coredump_var_addr" (I think this name is unique
>> enough). The patch below does that.
>>
>> WDYT?
>>
>> --
>> Sergio
>> GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
>> Please send encrypted e-mail if possible
>> http://sergiodj.net/
>>
>> gdb/testsuite/ChangeLog:
>> 2015-04-11 Sergio Durigan Junior <sergiodj@redhat.com>
>>
>> * gdb.base/coredump-filter.exp: Rename variable "addr" to
>> "coredump_var_addr" to avoid naming conflict with other
>> testcases.
>
> Ok by me with one nit.
> There's an issue here that still needs to be documented so it becomes
> part of the collective lore.
> Can this include a note about the need to give global array variables
> unique names to either testsuite/README or
> https://sourceware.org/gdb/wiki/Internals%20GDB-Testsuite-Coding-Standards
Thanks, pushed:
<https://sourceware.org/ml/gdb-cvs/2015-04/msg00095.html>
8cd8f2f8ac49276437b7da37f275706ea1c1c925
And updated the internals manual:
<https://sourceware.org/gdb/wiki/Internals%20GDB-Testsuite-Coding-Standards?action=recall&rev=3>
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/