Re: Patch, sim: fix m68hc11 and iq2000 testsuites using dejagnu baseboard files

[Mike Frysinger <vapier at gentoo dot org>]

On 07 Apr 2015 01:39, Hans-Peter Nilsson wrote:
> All of a sudden (thanks to Mike) m68hc11 and iq2000 sims both
> have test-suites, with a very welcome hello-world test.  But,
> for people expecting that to work with the corresponding
> supposedly-intended dejagnu baseboard, those tests fail linking.
> 
> For iq2000, iq2000-sim.exp has:
>  # Special linker script needed to run C programs.
>  set_board_info ldscript "-Tsim.ld"
> 
> but there's no sim.ld installed with today's binutils
> which is all we require for running the sim testsuite.
> (I see it's in libgloss.)
> 
> For m68hc11, there's a confusingly inconsistent comment and
> setting:
>  # No linker script needed.
>  set_board_info ldscript "-Wl,--script,sim-valid.x"
> 
> I'm not sure where the .x suffix comes from; libgloss would
> install a sim-valid.ld.  You might wonder how that gcc-specific
> "-Wl,"-syntax is supposed to work with a plain linker call.  The
> (IMHO) ugly truth is that default_link target.exp would strip a
> "-Wl,"-prefix, but it doesn't take care to *also* replace ","
> with " ", so I don't think that has ever worked with plain
> linker calls; those that end up in default_link calls.
> 
> Locally eliminating ldscript probably seems ugly.  There's
> precedent; see sim/testsuite/sim/mips/basic.exp.  An alternative
> would be to automatically disabling it in the first call to
> run_sim_test, but that seemed just too smart.

odd, it's working for me.  what is different about your environment ?  i'm just 
doing `make sim-check`.

i really don't want the sim to get into the business of fighting dejagnu over 
what a sane environment looks like.  but i also don't want to start sprinkling 
this logic over all targets.  so moving the existing mips logic to run_sim_test 
in lib/sim-defs.exp seems like the least worse option to me.
-mike

Attachment: signature.asc
Description: Digital signature