This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] [PATCH] Provide the ability to write the frame unwinder in Python
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Alexander Smundak <asmundak at google dot com>
- Cc: dje at google dot com, wingo at igalia dot com, gdb-patches at sourceware dot org
- Date: Thu, 26 Mar 2015 20:53:08 +0200
- Subject: Re: [RFC] [PATCH] Provide the ability to write the frame unwinder in Python
- Authentication-results: sourceware.org; auth=none
- References: <CAHQ51u7NUoQ8w9c5mc-Eiz05b1Nub6zqj_Ne7vfgWb5EP9_X8w at mail dot gmail dot com> <21714 dot 40641 dot 510825 dot 30998 at ruffy2 dot mtv dot corp dot google dot com> <CAHQ51u5_ViLaEmv9e43R-wzuWw8dwNkb-2XgCRy5ELQq5FUAWg at mail dot gmail dot com> <54E71694 dot 1080304 at redhat dot com> <CAHQ51u75+9HYAVJXYNQa0gTnQtYKEgmSkyAhAPYp-y4HGtXssg at mail dot gmail dot com> <CAHQ51u6UZ7A47rpGgX0QGeYSTCz1eo_3jWHc=q2ZX3YhqcJ6iQ at mail dot gmail dot com> <87ioei31uj dot fsf at igalia dot com> <CAHQ51u4f+Vx7qXPm-KAAENOceaVogMbDMw6==N_nY+GrLr4Pgg at mail dot gmail dot com> <87d24p19tt dot fsf at igalia dot com> <54FD7DAA dot 7010603 at redhat dot com> <CAHQ51u7sUkGhkmvTaaO_Jo6Jn+kojfiMWHmc2=7OWHThAq6EKw at mail dot gmail dot com> <87twxrncld dot fsf at igalia dot com> <CAHQ51u60nHp1a2DXZ4srvRefyTtge1BUw7-=JuYqChHN_wUGyQ at mail dot gmail dot com> <87ioe1dvu2 dot fsf at igalia dot com> <CAHQ51u7KzQLSLC=QeLA=zd+TUkbbNzzndfeVLFWpjiR-pL8ang at mail dot gmail dot com> <87sid4atms dot fsf at igalia dot com> <CAHQ51u6=9BKf6YSTavbY7u_Mi6miKJ_Yo1QcaG=KsYtYzoWY_Q at mail dot gmail dot com> <CAHQ51u4ybxem1X89G7frW-N_gZK6q3rKLunxgf+7UPzpswCfNg at mail dot gmail dot com> <87r3smado6 dot fsf at igalia dot com> <CAHQ51u6+sCwS at [87 dot 69 dot 4 dot 28]>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
- Sun-java-system-smtp-warning: Lines longer than SMTP allows found and truncated.
> Date: Wed, 25 Mar 2015 20:31:09 -0700
> From: Alexander Smundak <asmundak@google.com>
> Cc: Andy Wingo <wingo@igalia.com>, gdb-patches <gdb-patches@sourceware.org>
>
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -12,6 +12,7 @@
> ** gdb.Objfile objects have a new attribute "username",
> which is the name of the objfile as specified by the user,
> without, for example, resolving symlinks.
> + ** You can now write frame unwinders in Python.
This part is OK.
> +@node Unwinding Frames in Python
> +@subsubsection Unwinding Frames in Python
> +@cindex Unwinding frames in Python.
@cindex entries should generally begin with a lower-case letter.
That's because alphabetic sorting in various locales might produce
different orders when mixed-case letters are involved, so the order in
the Index nodes will be different depending on where the manual was
produced. We want to avoid that.
> +In GDB terminology ``unwinding'' is the process of finding the
^^^
"@value{GDBN}" (here and elsewhere in the patch).
> +previous frame (that is, caller's) from the current one. An unwinder
^^
Two spaces between sentences (here and elsewhere in the patch).
> +(for example, and application running Java Virtual Machine) sometimes
^^^
"an"
> +returns an object (an instance of gdb.UnwindInfo class) describing
^^^^^^^^^^^^^^
This should be in @code, as it's a Python symbol.
> +usually found in the corresponding xxx-@code{tdep.h} file in the gdb
^^^^^^^^^^^^^^^^^
It is better to write @file{@var{platform}-tdep.h} here; this explains
better what is that "xxx" in the text.
> +It also provides a factory method to create a gdb.UnwindInfo instance
^^^^^^^^^^^^^^
@code
> +using one of the @code{frame_id_build_xxx} functions. The exact
Once again, please try a way to make "xxx" more clear, as I did above.
Thanks.