Re: [PATCH] btrace: fix tests for 32-bit

[Pedro Alves <palves at redhat dot com>]

On 03/03/2015 12:01 PM, Markus Metzger wrote:
> The x86-record_goto.S assembly source file does not build on 32-bit.
> This breaks many tests that use this file.
> 
> Split it into x86_64-record_goto.S and i686-record_goto.S.  Luckily, we
> can use either one with the same test .exp file.
> 
> It further turned out that most tests do not really need a fixed binary;
> they should work pretty well with a newly-compiled C program.  The
> one thing that breaks this is the heavy use of "record goto" to navigate
> inside the recorded execution.

OOC, why do we need .S files for "record goto"?  Can we have a
comment somewhere mentioning that?

> 
> Combine step.exp, next,exp, and finish.exp into a single test step.exp
> and use normal stepping and reverse-stepping commands for navigation.
> 

> --- a/gdb/testsuite/gdb.btrace/step.exp
> +++ b/gdb/testsuite/gdb.btrace/step.exp
> @@ -20,9 +20,10 @@
>  # check for btrace support
>  if { [skip_btrace_tests] } { return -1 }
>
> +standard_testfile record_goto.c
> +
>  # start inferior
> -standard_testfile x86-record_goto.S
> -if [prepare_for_testing step.exp $testfile $srcfile] {
> +if [prepare_for_testing finish.exp $testfile $srcfile] {

Typo here.                 ^^^^^^^^^^

Otherwise looks fine to me.

Thanks,
Pedro Alves