This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/4] GDBServer: introduce --server-stderr command line option
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Cleber Rosa <crosa at redhat dot com>
- Cc: gdb-patches at sourceware dot org, areis at redhat dot com
- Date: Mon, 23 Mar 2015 21:12:13 +0200
- Subject: Re: [PATCH 3/4] GDBServer: introduce --server-stderr command line option
- Authentication-results: sourceware.org; auth=none
- References: <1426905265-8495-1-git-send-email-crosa at redhat dot com> <1426905265-8495-4-git-send-email-crosa at redhat dot com> <83384yvjr0 dot fsf at gnu dot org> <55105FFD dot 60204 at redhat dot com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Mon, 23 Mar 2015 15:48:29 -0300
> From: Cleber Rosa <crosa@redhat.com>
> CC: gdb-patches@sourceware.org, areis@redhat.com
>
> >> +@item --server-stderr
> >> +Instruct @code{gdbserver} to redirect its own @code{stderr} to another
> >> +file.
> > The option requires an argument, so the argument should be mentioned
> > with the option and referenced in the text that describes it.
>
> Sure, I also feel an example could help. How do you feel about this:
>
> @cindex @option{--server-output}, @code{gdbserver} option
> The @option{--server-output=path} option tells @code{gdbserver} to send
@option{--server-output=@var{path}} (and once again, please use
"file" or "filename", not "path").
Also, what happened to the @item?
> all its output to a file given by @var{path}. This can be useful, for
^^
Two spaces between sentences.
> @smallexample
> $ gdbserver --server-output=server.log :2222 testprog >test.out 2>test.err
> @end smallexample
This line is too long; either try to make it shorter, e.g., by using
shorter file/program names, or break it into 2 lines.
Otherwise, this is fine, thanks.
> > AFAIK, GNU Coding Standards frown on using "path" for anything that is
> > not PATH-style list of directories. So please use "file" or "file
> > name" here.
>
> I could not find a mention on the GNU Coding Standards manual itself,
It's in the node "GNU Manuals":
Please do not use the term "pathname" that is used in Unix
documentation; use "file name" (two words) instead. We use the term
"path" only for search paths, which are lists of directory names.