This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/2] Implement breakpoint_find_if
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>
- Date: Wed, 11 Mar 2015 11:22:51 +0000
- Subject: Re: [PATCH 1/2] Implement breakpoint_find_if
- Authentication-results: sourceware.org; auth=none
- References: <1426030105-15485-1-git-send-email-sergiodj at redhat dot com> <1426030105-15485-2-git-send-email-sergiodj at redhat dot com>
Sergio Durigan Junior <sergiodj@redhat.com> writes:
> My first thought was to share the ALL_BREAKPOINTS* macros on
> gdb/breakpoint.h, but they use a global variable local to
> gdb/breakpoint.c, and I did not want to share that variable. So, in
> order to keep the minimal separation, I decided to implement this
> way of iterating through the existing 'struct breakpoint *'.
Yeah, I agree that we should keep these variables private.
>
> This function was based on BFD's bfd_sections_find_if. If the
> user-provided function returns 0, the iteration proceeds. Otherwise,
> the iteration stops and the function returns the 'struct breakpoint *'
> that is being processed. This means that the return value of this
> function can be either NULL or a pointer to a 'struct breakpoint'.
This is fine by me. breakpoint_find_if can be more widely used so that
some other code in breakpoint.c can be moved out.
--
Yao (éå)