This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3 05/14] sim/erc32: Use memory_iread() function for instruction fetching.

On 01 Mar 2015 22:10, Jiri Gaisler wrote:
> --- a/sim/erc32/erc32.c
> +++ b/sim/erc32/erc32.c
>
> +	return (0);

drop the paren

> +	return (0);

here too

> +    printf("Memory exception at %x (illegal address)\n", addr);

space after the printf

should this be writing to stderr ?

> --- a/sim/erc32/interf.c
> +++ b/sim/erc32/interf.c
>
> +        mexc = memory_iread(sregs->pc, &sregs->inst, &sregs->hold);

space before the (
-mike

Attachment: signature.asc
Description: Digital signature

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]