This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Retrieve segment registers on Windows amd64
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Jon TURNEY <jon dot turney at dronecode dot org dot uk>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 26 Feb 2015 10:23:33 +0100
- Subject: Re: [PATCH] Retrieve segment registers on Windows amd64
- Authentication-results: sourceware.org; auth=none
- References: <1424435625-3708-1-git-send-email-jon dot turney at dronecode dot org dot uk>
Jon,
> For amd64, CONTEXT_FULL does not contain CONTEXT_SEGMENTS, which seems to be
> needed to retrieve all the segment registers. Add it explicitly, with
> a little de-cruftification.
>
> The value of the segment registers isn't terribly useful on amd64, but
> at least this makes the output of 'info registers' correct.
>
> before:
>
> (gdb) i r cs ss ds es fs gs
> cs 0x33 51
> ss 0x2b 43
> ds 0x0 0
> es 0x0 0
> fs 0x0 0
> gs 0x0 0
>
> after:
>
> (gdb) i r cs ss ds es fs gs
> cs 0x33 51
> ss 0x2b 43
> ds 0x2b 43
> es 0x2b 43
> fs 0x53 83
> gs 0x2b 43
>
> gdb/ChangeLog
>
> 2015-02-19 Jon TURNEY <jon.turney@dronecode.org.uk>
>
> * windows-nat.c (CONTEXT_DEBUGGER_DR): Add CONTEXT_SEGMENTS.
Thanks for the patch.
The patch looks good to me.
The ChangeLog needs to identify all the changes were made, and in
particular, it needs to mention the fact that CONTEXT_DEBUGGER's
declaration was removed.
Do you have a GDB copyright assignment on file. The patch is small
enough that we can take it as a "tiny patch", but if you have other
patches in the pipeline, then you'll eventually need to fill one out.
Let me know if you'd like to get started on the process, it takes
a few weeks to complete, as I understand it.
--
Joel