This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Build failure with probe patch
- From: Steve Ellcey <sellcey at imgtec dot com>
- To: "Jose E. Marchesi" <jose dot marchesi at oracle dot com>
- Cc: Pedro Alves <palves at redhat dot com>, Sergio Durigan Junior <sergiodj at redhat dot com>, <gdb-patches at sourceware dot org>
- Date: Thu, 19 Feb 2015 09:48:39 -0800
- Subject: Re: Build failure with probe patch
- Authentication-results: sourceware.org; auth=none
- References: <bac100bc-73de-4bf6-86b5-912ad6887c5a at BAMAIL02 dot ba dot imgtec dot org> <87wq3ercw0 dot fsf at redhat dot com> <1424306916 dot 27855 dot 115 dot camel at ubuntu-sellcey> <87r3tl7uwz dot fsf at oracle dot com> <54E6150B dot 9060808 at redhat dot com> <87vbix3iqm dot fsf at oracle dot com>
- Reply-to: <sellcey at imgtec dot com>
On Thu, 2015-02-19 at 18:37 +0100, Jose E. Marchesi wrote:
> I see, void is not allowed to alias a char... we are doomed! :D
>
> Oh well, I guess we will have to use an union to avoid any possible
> strict-aliasing warning... Can we assume C99 in GDB?
Even with this issue fixed I ran into one other compiler problem. I get
this error from GCC 4.1.2:
cc1: warnings being treated as errors
/scratch/sellcey/gdb-bug/src/gdb/gdb/dtrace-probe.c: In function 'dtrace_get_probes':
/scratch/sellcey/gdb-bug/src/gdb/gdb/dtrace-probe.c:64: warning: 'arg.expr' is used uninitialized in this function
To fix this problem I changed dtrace_process_dof_probe to have
'arg.expr = NULL' in the loop that stores argument descriptions. Here
is a complete patch that compiled for me using the old GCC.
Steve Ellcey
sellcey@imgtec.com
diff --git a/gdb/dtrace-probe.c b/gdb/dtrace-probe.c
index a6544ba..fd6ae6e 100644
--- a/gdb/dtrace-probe.c
+++ b/gdb/dtrace-probe.c
@@ -415,6 +415,7 @@ dtrace_process_dof_probe (struct objfile *objfile,
struct dtrace_probe_arg arg;
struct expression *expr;
+ arg.expr = NULL;
arg.type_str = xstrdup (p);
/* Use strtab_size as a sentinel. */
@@ -617,17 +618,17 @@ dtrace_get_probes (VEC (probe_p) **probesp, struct objfile *objfile)
{
if (elf_section_data (sect)->this_hdr.sh_type == SHT_SUNW_dof)
{
- struct dtrace_dof_hdr *dof;
+ bfd_byte *dof;
/* Read the contents of the DOF section and then process it to
extract the information of any probe defined into it. */
- if (!bfd_malloc_and_get_section (abfd, sect, (bfd_byte **) &dof))
+ if (!bfd_malloc_and_get_section (abfd, sect, &dof))
complaint (&symfile_complaints,
_("could not obtain the contents of"
"section '%s' in objfile `%s'."),
sect->name, abfd->filename);
- dtrace_process_dof (sect, objfile, probesp, dof);
+ dtrace_process_dof (sect, objfile, probesp, (struct dtrace_dof_hdr *) dof);
xfree (dof);
}
}