This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Asynchronously resize the TUI


On Wed, Feb 18, 2015 at 4:59 AM, Pedro Alves <palves@redhat.com> wrote:
> On 02/18/2015 12:36 AM, Patrick Palka wrote:
>
>> gdb/ChangeLog:
>>
>>       * tui/tui-io.c (tui_handle_resize_during_io): Remove this
>>       function.
>>       (tui_putc): Don't call tui_handle_resize_during_io.
>>       (tui_getc): Likewise.
>>       (tui_mld_getc): Likewise.
>>       * tui/tui-win.c: Include event-loop.h and tui/tui-io.h.
>>       (tui_sigwinch_token): New static variable.
>>       (tui_initialize_win): Adjust documentation.  Set
>>       tui_sigwinch_token.
>>       (tui_async_resize_screen): New asynchronous callback.
>>       (tui_sigwinch_handler): Adjust documentation.  Asynchronously
>>       invoke tui_async_resize_screen.
>
>
> OK.  Thanks for doing this!

Thanks for reviewing.  I have committed the patch in two pieces
because I forgot to add the gdb/ChangeLog entry in the first commit.
Sorry about that...

BTW shouldn't the object returned by create_async_signal_handler() be
eventually deallocated via delete_async_event_handler() at some point?
 It doesn't seem that we do this for any async signal handler
currently in use so far..

>
> Thanks,
> Pedro Alves
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]