This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] sim/mcore/interp.c: Include "unistd.h" standard C header file to avoid compiling warnings.
- From: Chen Gang S <gang dot chen at sunrus dot com dot cn>
- To: Doug Evans <xdje42 at gmail dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Sun, 08 Feb 2015 09:40:00 +0800
- Subject: Re: [PATCH] sim/mcore/interp.c: Include "unistd.h" standard C header file to avoid compiling warnings.
- Authentication-results: sourceware.org; auth=none
- References: <54D61EFC dot 3040000 at sunrus dot com dot cn> <CAP9bCMT1=7ufFF0hBuTre8VJSMOJBxMHKk77V7+wkymKd9fQVw at mail dot gmail dot com> <54D6A794 dot 7080107 at sunrus dot com dot cn> <CAP9bCMQUMXWOmicLmHajeKBPXmdybdZgtq9WW-z5fAa+ks4dBQ at mail dot gmail dot com>
On 2/8/15 08:35, Doug Evans wrote:
> On Sat, Feb 7, 2015 at 4:02 PM, Chen Gang S <gang.chen@sunrus.com.cn> wrote:
>> On 2/8/15 07:22, Doug Evans wrote:
>>> On Sat, Feb 7, 2015 at 6:19 AM, Chen Gang S <gang.chen@sunrus.com.cn> wrote:
>>>> The related warnings:
>>>>
>>>> gcc -DHAVE_CONFIG_H -DPROFILE=1 -DWITH_PROFILE=-1 -DDEFAULT_INLINE=0 -I. -I../../../binutils-gdb/sim/mcore -I../common -I../../../binutils-gdb/sim/mcore/../common -I../../include -I../../../binutils-gdb/sim/mcore/../../include -I../../bfd -I../../../binutils-gdb/sim/mcore/../../bfd -I../../opcodes -I../../../binutils-gdb/sim/mcore/../../opcodes -g -O2 -c -o interp.o -MT interp.o -MMD -MP -MF .deps/interp.Tpo ../../../binutils-gdb/sim/mcore/interp.c
>>>> ../../../binutils-gdb/sim/mcore/interp.c: In function âhandle_trap1â:
>>>> ../../../binutils-gdb/sim/mcore/interp.c:559:22: warning: implicit declaration of function âlinkâ [-Wimplicit-function-declaration]
>>>> cpu.gr[RET1] = link ((char *) a[0], (char *) a[1]);
>>>> ^
>>>> ../../../binutils-gdb/sim/mcore/interp.c:585:22: warning: implicit declaration of function âaccessâ [-Wimplicit-function-declaration]
>>>> cpu.gr[RET1] = access ((char *) a[0], a[1]);
>>>> ^
>>>>
>>>> 2015-02-07 Chen Gang <gang.chen.5i5j@gmail.com>
>>>>
>>>> * mcore/interp.c: Include "unistd.h" standard C header file to
>>>> avoid compiling warnings.
>>>
>>> LGTM
>>
>> Excuse me, I am not quite familiar with the short word, I guess it is "
>> Look Good To ME",
>>
>> Is what I guess correct?
>
> Looks Good To Me,
> yeah
Thank you for your work, and I shall "git push" to main branch, if no
additional reply within 3 days (2015-02-10).
Thanks.
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed