This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/6] Mention which return values need to be freed in lang_varobj_ops
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sat, 31 Jan 2015 07:20:46 +0400
- Subject: Re: [PATCH 2/6] Mention which return values need to be freed in lang_varobj_ops
- Authentication-results: sourceware.org; auth=none
- References: <1422559716-5480-1-git-send-email-simon dot marchi at ericsson dot com> <1422559716-5480-2-git-send-email-simon dot marchi at ericsson dot com> <20150130032848 dot GK5193 at adacore dot com> <54CBB44C dot 8040701 at ericsson dot com>
> After looking more closely, I think you are right. Originally, I saw that
> install_new_value called value_free on the old value and jumped to the
> conclusion. Actually, value_free is more like a "value_decref", which
> frees the variable if the reference count drops to 0. The call to
> value_free just matches the value_incref that was also done in
> install_new_value when we installed the value. So just calling
> value_of_child doesn't mean that you have to call value_free.
Good :).
> Thanks for the explanation, I didn't know about the memory management of
> values. I'll remove the comment change for value_of_child. Is the rest of
> the patch ok?
Yes, it is. Go ahead and push the version without this particular
comment change.
--
Joel