This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/6] Mention which return values need to be freed in lang_varobj_ops
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 30 Jan 2015 07:28:48 +0400
- Subject: Re: [PATCH 2/6] Mention which return values need to be freed in lang_varobj_ops
- Authentication-results: sourceware.org; auth=none
- References: <1422559716-5480-1-git-send-email-simon dot marchi at ericsson dot com> <1422559716-5480-2-git-send-email-simon dot marchi at ericsson dot com>
> gdb/ChangeLog:
>
> * varobj.h (lang_varobj_ops): Mention which return values need
> to be freed.
Thanks for doing that! One question...
> - /* The ``struct value *'' of the INDEX'th child of PARENT. */
> + /* The ``struct value *'' of the INDEX'th child of PARENT. The returned
> + value must be freed by the caller. */
> struct value *(*value_of_child) (struct varobj *parent, int index);
I'm really surprised by this. For memory management, the struct value
objects are put on a chain. So, you wouldn't delete the value returned,
but you would instead use "value_mark/value_free_to_mark". The top-level
command loop takes a mark at the beginning of the command, and uses it
to free any un-freed value after the command completes.
But maybe you saw something that contradicts my understanding?
--
Joel