This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] TUI: Expand TABs into spaces
- From: Doug Evans <xdje42 at gmail dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Fri, 16 Jan 2015 09:29:52 -0800
- Subject: Re: [PATCH] TUI: Expand TABs into spaces
- Authentication-results: sourceware.org; auth=none
- References: <83k3149k5b dot fsf at gnu dot org> <837fwn2cvc dot fsf at gnu dot org> <CAP9bCMSbzc3q5CmJQDZyL0utP_x6Sp8ekHaTHzJHyVCJRwwcWA at mail dot gmail dot com> <83iog61xrl dot fsf at gnu dot org>
On Fri, Jan 16, 2015 at 8:43 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Fri, 16 Jan 2015 08:32:15 -0800
>> From: Doug Evans <xdje42@gmail.com>
>> Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
>>
>> >> 2015-01-03 Eli Zaretskii <eliz@gnu.org>
>> >>
>> >> * tui/tui-regs.c (tui_register_format): Expand TABs into the
>> >> appropriate number of spaces.
>> >>
>> >> * tui/tui-io.c (tui_puts, tui_redisplay_readline): Expand TABs
>> >> into the appropriate number of spaces.
>>
>> I'd have to read the patch more to say it's ok,
>> but one thing that is missing are comments
>> explaining *why* we are expanding tabs into spaces.
>
> You mean, the fact that the Windows port of ncurses doesn't? Sure,
> can do that. But note that a similar feature in displaying the source
> doesn't have any such comments.
Is that in relation to the tabset command?
And is that to provide a knob so that source written
with an expectation that \t was different than 8
can be made readable?
Or is there existing code that is coping with these
windows, umm, quirks?