This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Clear upper bits during sign extension
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 08 Jan 2015 10:41:57 +0000
- Subject: Re: [PATCH] Clear upper bits during sign extension
- Authentication-results: sourceware.org; auth=none
- References: <1419815569-21854-1-git-send-email-yao at codesourcery dot com> <54A13184 dot 1070902 at redhat dot com> <874msdwl39 dot fsf at codesourcery dot com> <54A29886 dot 8030603 at redhat dot com> <87vbktuu5p dot fsf at codesourcery dot com> <87bnm9u8wx dot fsf at codesourcery dot com>
On 01/08/2015 05:40 AM, Yao Qi wrote:
> Yao Qi <yao@codesourcery.com> writes:
>
>>> + byte_order = gdbarch_byte_order (get_type_arch (type));
>>
>> How about getting gdbarch via get_frame_arch (frame)? How about
>> removing gdb_sign_extend as it is no longer used?
>>
>> I'll post a full version on top of yours.
>
> Here is the patch, what do you think?
Looks good to me. Thanks.
--
Pedro Alves