This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCHSET] [2/4] Fix various issue in TUI


On 01/06/2015 03:55 PM, Eli Zaretskii wrote:

> 2015-01-06  Eli Zaretskii  <eliz@gnu.org>
> 
> 	* tui/tui-win.c (tui_set_var_cmd): New function.
> 	(_initialize_tui_win) <border-kind, border-mode>:
> 	<active-border-mode>: Use tui_set_var_cmd as the "set" function.
> 
> --- gdb/tui/tui-win.c~2	2015-01-04 08:07:30 +0200
> +++ gdb/tui/tui-win.c	2015-01-06 08:03:05 +0200
> @@ -346,6 +346,12 @@ tui_get_cmd_list (void)
>    return &tuilist;
>  }
>  
> +void tui_set_var_cmd (char *null_args, int from_tty, struct cmd_list_element *c)

Line break after "void".  Misses an intro comment, maybe something
like:

/* The set_func hook of "set tui ..." settings that affect
   the TUI display.  */

> +{
> +  if (tui_update_variables ())
> +    tui_rehighlight_all ();

The tui_rehighlight_all function is missing in this patch.
Did you indend for this to be tui_refresh_all_win?

Is this OK to call when the tui is not enabled?

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]