This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [mingw rfc] Add mkdtemp to gdb/gnulib/ [Re: [PATCH v4 14/14] the "compile" command]
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Yao Qi <yao at codesourcery dot com>, gdb-patches at sourceware dot org, Kai Tietz <ktietz at redhat dot com>
- Date: Mon, 15 Dec 2014 18:12:25 +0100
- Subject: Re: [mingw rfc] Add mkdtemp to gdb/gnulib/ [Re: [PATCH v4 14/14] the "compile" command]
- Authentication-results: sourceware.org; auth=none
- References: <20141123192713 dot 32193 dot 57150 dot stgit at host1 dot jankratochvil dot net> <20141123192900 dot 32193 dot 65726 dot stgit at host1 dot jankratochvil dot net> <87r3w2vkhv dot fsf at codesourcery dot com> <20141214075258 dot GA26795 at host2 dot jankratochvil dot net> <87egs2vcfu dot fsf at codesourcery dot com> <20141214182341 dot GA2908 at host2 dot jankratochvil dot net> <87a92pvc0w dot fsf at codesourcery dot com> <20141215124358 dot GU5457 at adacore dot com>
On Mon, 15 Dec 2014 13:43:58 +0100, Joel Brobecker wrote:
> I would personally take a two-step approach: First, immediately
> fix the build issue using the second recommendation you made, which
> is to use win32 routines on Windows hosts for now. Then, we can
> work towards first upgrading gnulib, and then importing mkdtemp.
> I find that updating gnulib to always be fairly disruptive, which
> is why I propose we stabilize the problem first to get builds
> working back ASAP, and then look at gnulib.
Does it mean that after upgrading gnulib we can drop the MS-Windows host
routines (which need to be written yet) again?
IMO a more clean solution would be s/gdb_select/select/g, drop gdb_select from
mingw-hdep.c and import gnulib select instead which handles what gdb_select is
there fore, hopefully more transparently. But I haven't tried any of that.
Jan