This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC/RFT] Use core regset iterators on Sparc Solaris
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: brobecker at adacore dot com (Joel Brobecker)
- Cc: gdb-patches at sourceware dot org, davem at redhat dot com
- Date: Wed, 3 Dec 2014 15:42:23 +0100 (CET)
- Subject: Re: [RFC/RFT] Use core regset iterators on Sparc Solaris
- Authentication-results: sourceware.org; auth=none
Joel Brobecker wrote:
> > gdb/
> > * config/sparc/sol2.mh (NATDEPFILES): Remove core-regset.o.
> > * sparc-sol2-tdep.c: Include "regset.h".
> > (sparc32_sol2_supply_core_gregset): New function.
> > (sparc32_sol2_collect_core_gregset): Likewise.
> > (sparc32_sol2_supply_core_fpregset): Likewise.
> > (sparc32_sol2_collect_core_fpregset): Likewise.
> > (sparc32_sol2_gregset, sparc32_sol2_fpregset): New variables.
> > (sparc32_sol2_init_abi): Set tdep->gregset/sizeof_gregset and
> > tdep->fpregset/sizeof_fpregset.
> > * sparc64-sol2-tdep.c: Include "regset.h".
> > (sparc64_sol2_supply_core_gregset): New function.
> > (sparc64_sol2_collect_core_gregset): Likewise.
> > (sparc64_sol2_supply_core_fpregset): Likewise.
> > (sparc64_sol2_collect_core_fpregset): Likewise.
> > (sparc64_sol2_gregset, sparc64_sol2_fpregset): New variables.
> > (sparc64_sol2_init_abi): Set tdep->gregset/sizeof_gregset and
> > tdep->fpregset/sizeof_fpregset.
>
> I tested this patch on sparc-solaris using AdaCore's testsuite,
> and it revealed no regression, and in particular testcases involving
> the use of core files continued passing.
Excellent! Many thanks for testing!
I've now pushed this patch.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com