This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/3] python extended prompt: Use os.getcwd() instead of os.getcwdu()
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: <gdb-patches at sourceware dot org>, <simon dot marchi at polymtl dot ca>
- Date: Fri, 28 Nov 2014 10:49:22 -0500
- Subject: Re: [PATCH 1/3] python extended prompt: Use os.getcwd() instead of os.getcwdu()
- Authentication-results: sourceware.org; auth=none
- References: <1416976561-1927-1-git-send-email-simon dot marchi at ericsson dot com> <20141127090037 dot GG5042 at adacore dot com>
> I'd like to have other people's opinion on this, as I am not sure.
>
> I _think_ that the patch is not making things worse for us,
> while making things a little better in situations as the above.
> So, based on that, I'd be inclined to apply it.
>
> However, I think the long term fix would be, I believe, to switch
> the entire thing to unicode. With Python3, it's automatic, but
> with Python2, we might have to add 'u'-s on every piece of string
> in the module, and also add some conversions here and there.
> That's why I am thinking that the long term fix should be a blocker
> for this patch.
>
> Thoughts?
An eventual switch to use unicode everywhere would certainly undo this
patch. However, I don't see the point in leaving the broken code as-is,
unless there are imminent plans to make that switch happen.
Simon