This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] frame.c: Fix the check for FID_STACK_INVALID in frame_id_eq().
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Martin Galvan <martin dot galvan at tallertechnologies dot com>
- Cc: gdb-patches at sourceware dot org, daniel dot gutson at tallertechnologies dot com
- Date: Tue, 25 Nov 2014 15:32:54 -0500
- Subject: Re: [PATCH] frame.c: Fix the check for FID_STACK_INVALID in frame_id_eq().
- Authentication-results: sourceware.org; auth=none
- References: <1416944088-8750-1-git-send-email-martin dot galvan at tallertechnologies dot com>
On Tuesday, November 25 2014, Martin Galvan wrote:
> I noticed in frame_id_eq() we were checking for the "l" frame_id being invalid twice instead of checking both "l" and "r", so I corrected it.
Hi Martin,
Thanks for the patch. I guess it is obvious enough that it could be
checked in without approval, but just to be safe, let's wait until a
maintainer approves it. Meanwhile...
> gdb/ChangeLog:
>
> 2014-11-25 Martin Galvan <martin.galvan@tallertechnologies.com>
>
> * frame.c (frame_id_eq): Fix the check for FID_STACK_INVALID.
The indentation of this ChangeLog entry is wrong. You must use TAB
instead of whitespaces to indent the "*" part.
> ---
>
> diff --git a/gdb/frame.c b/gdb/frame.c
> index 0663af9..135b820 100644
> --- a/gdb/frame.c
> +++ b/gdb/frame.c
> @@ -614,7 +614,7 @@ frame_id_eq (struct frame_id l, struct frame_id r)
> outer_frame_id. */
> eq = 1;
> else if (l.stack_status == FID_STACK_INVALID
> - || l.stack_status == FID_STACK_INVALID)
> + || r.stack_status == FID_STACK_INVALID)
Here, the use of whitespaces is wrong too. And it seems your e-mail
client has mangled the TAB of the old code as well.
> /* Like a NaN, if either ID is invalid, the result is false.
> Note that a frame ID is invalid iff it is the null frame ID. */
> eq = 0;
--
Sergio
GPG key ID: 0x65FC5E36
Please send encrypted e-mail if possible
http://sergiodj.net/